Skip to content

upgrade CI, format#125

Merged
warmwaffles merged 6 commits intomainfrom
kcl-win-ci
Mar 23, 2021
Merged

upgrade CI, format#125
warmwaffles merged 6 commits intomainfrom
kcl-win-ci

Conversation

@kevinlang
Copy link
Copy Markdown
Member

@kevinlang kevinlang commented Mar 22, 2021

This is adopted from the pattern Dashbit uses. E.g.,

https://github.com/dashbitco/mox/blob/master/.github/workflows/ci.yml

CI should run a bit faster now, and this setup will also allow us to leverage the improvements of the underlying action that is supported by the Erlang Foundation.

Original intent was to do this for Windows support, but it looks like it does not support Windows yet :(

@kevinlang kevinlang changed the title upgrade CI, add windows CI upgrade CI Mar 23, 2021
@kevinlang kevinlang changed the title upgrade CI upgrade CI, format Mar 23, 2021
Copy link
Copy Markdown
Contributor

@cw789 cw789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably overseen from the reference.

Comment thread .github/workflows/ci.yml Outdated
pull_request:
push:
branches:
- master
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default branch is main.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@warmwaffles warmwaffles merged commit d343d60 into main Mar 23, 2021
@warmwaffles warmwaffles deleted the kcl-win-ci branch March 23, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants